From nobody Mon Oct  5 13:43:34 2026
X-Original-To: net@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hz0w65L7cz6jsn5
	for <net@mlmmj.nyi.freebsd.org>; Mon, 05 Oct 2026 13:43:34 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4hz0w64cPYz4sRh
	for <net@FreeBSD.org>; Mon, 05 Oct 2026 13:43:34 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1791207814;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mAEqbiJwATlrmk5XkbdbNznGk7gMmMoR1xHSmdlGaMk=;
	b=Ub2vUBc8z/2NVQbM8r/Pep2obBa9zIbVCs2yMwBFU1LkYbJa1k6wKXzji6WFslbAt7QNPC
	pHWv5vQAH9iZZ6WL6OMe5cD6B6r3i1qKaXw7y4zK9pkUMIfg2OMmR82ANERJvd8IAfIQFN
	Y6uJePJRShcb6pSNiKfbZ9OoJDK/7rCZrLhfynnCBpfhXeY5OaouNDVAg9BUMwlp8pZmpn
	gfjfwTesfHgPvixEwJFc4Grz92S/918AyQdLsPle1FolKPqfMiT9ahrfzQtKNe8XQ9iB2Y
	3C/jBFfAtNcw16rT++wYJsSN7ApoVn1DypDkAjYA6S0AvRf0dzNdblWUpRhc/g==
ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791207814;
	b=E5+DxTZTfWaoIPzWiNmCKv2mjiX3epDG5OGTMjjSbN6GSo1EVI0QDXeN021jkBe5Yvm/ud
	M/KW5P9EKPOY+qMcTN4V3ZAwF/RKLRgYwc/ky6oGcHcfS+ylNEvzIHxWss9W4VhWCZ30FS
	wi4YkNF6GSby3l8IucQIkCFWYALhrP1bdb0vonsH/fhq5v/NILJhNM+zhxpS1IrcLgBu9A
	w1iMnDpey8a4oOjR3ZJIEvpm1eSPM/que9ytB5vxgDHwZU45cg3LvMvs5cwA7CnknyNo7B
	KPkljrkbrjTxd+RAx+VPIP/NUYiArS1AYLALBvml0ax1FOXbsgP8S2CLd8Gbcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1791207814;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mAEqbiJwATlrmk5XkbdbNznGk7gMmMoR1xHSmdlGaMk=;
	b=dJNMKmpjwMBPMMjBQ0MV1Fd7ZmPFdb6Frzl4e3nXTJel9GdCj09yLug0iHmiLdLXXp97cm
	V7fXHc0//CVW64KHxW3MO4//4DJdrn3CTob69wCDlWqqObzyV7F6H2Q+hOEJbY3aueMsMD
	ISdv2eYZkhBRutMRxrlqYALDTOOxMdA/uWg9dSrxgao3qHVV76HPVgXWhBoKfbxa63vo0H
	wjo1R3j0g4Kn9qET/HQzx6cde45FrLecAWfzyCJbhhmV8EmCBoUlxdcu4aOO+QBSj0GfEz
	Kj1klqkLAjf62p4YTugtsv3ZHWCH9QiEHa/VdhhLBvTVnFMekRlbqTxGvHGViA==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4hz0w63hGczLjk
	for <net@FreeBSD.org>; Mon, 05 Oct 2026 13:43:34 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org ([127.0.1.5])
	by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 695DhY2D014557
	for <net@FreeBSD.org>; Mon, 5 Oct 2026 13:43:34 GMT
	(envelope-from bugzilla-noreply@freebsd.org)
Received: (from www@localhost)
	by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 695DhYmt014556
	for net@FreeBSD.org; Mon, 5 Oct 2026 13:43:34 GMT
	(envelope-from bugzilla-noreply@freebsd.org)
X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f
From: bugzilla-noreply@freebsd.org
To: net@FreeBSD.org
Subject: [Bug 299065] LINT builds are failing on aarch64/amd64 due to missing
 symbols with if_bnxt driver
Date: Mon, 05 Oct 2026 13:43:34 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 15.1-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: ssaxena@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: net@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-299065-7501-tUh1o8H1f6@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-299065-7501@https.bugs.freebsd.org/bugzilla/>
References: <bug-299065-7501@https.bugs.freebsd.org/bugzilla/>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-net
List-Help: <mailto:freebsd-net+help@freebsd.org>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Subscribe: <mailto:freebsd-net+subscribe@freebsd.org>
List-Unsubscribe: <mailto:freebsd-net+unsubscribe@freebsd.org>
Sender: owner-freebsd-net@FreeBSD.org
List-Id: <freebsd-net.FreeBSD.org>
List-Post: <mailto:freebsd-net@FreeBSD.org>
List-Help: <mailto:freebsd-net+help@FreeBSD.org>
List-Subscribe: <mailto:freebsd-net+subscribe@FreeBSD.org>
List-Unsubscribe: <mailto:freebsd-net+unsubscribe@FreeBSD.org>
List-Owner: <mailto:postmaster@FreeBSD.org>
Precedence: list
MIME-Version: 1.0

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D299065

--- Comment #1 from Sumit Saxena <ssaxena@FreeBSD.org> ---
The following commit has been cherry-picked into stable/15 and should resol=
ve
this issue:

8bf2795588c3 - stable/15 - bnxt_en: add bnxt_sriov.c to sys/conf/files for
built-in kernel builds

--=20
You are receiving this mail because:
You are the assignee for the bug.=

From nobody Mon Oct  5 15:41:00 2026
X-Original-To: net@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hz3Wd1tKgz6k3Wv
	for <net@mlmmj.nyi.freebsd.org>; Mon, 05 Oct 2026 15:41:01 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4hz3Wd1MT9z4Fcm
	for <net@FreeBSD.org>; Mon, 05 Oct 2026 15:41:01 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1791214861;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UVO7LbGOAGo9OqVSQSLUeUOmvwKVDCLK1lhx1pC6RKc=;
	b=f5HzE205qL9WCRTrmHjzREIMnMfNKrxEGXsWrGJ4Ear1pTH7I2ddr4nYXET3ydKgTMqEYY
	mqKDjvIX54xTcw9n4loNXfi29oE0SjkV8vjPULWcKTveaE4dADUyMtY2pCI2FPQqGQGmR9
	rwMtHNqapSWE0NLou0YImSlE6L/JsYSxlh+FpBYmNLj8WZaeoLs1iNogbovIFa6kOrskaf
	uLA1DrTscmk5ADZtFwvI00UMqYitOKyN7f7CziiidzDHVSOVVZgcfWjEt971EaM69zHeJz
	QXnPsjg67fjNVfmK8cWCep44j3EILe1HmBYFtP8mj+g0Kssf2Rm4Zf5zFiWYPA==
ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791214861;
	b=wrLqlmtldgaLvy44ZoRmgwCcTH9ucM5yjjAowOoWs6uTHCsopWIc/PsXUJigcM3SXWySxq
	nVWr6YVnicDqhbNCnhDNJoZoI/ReP7idDzJU/tdgpw8m45oiKyK1e/NoIYgSiDrQ2omY0x
	o0zfKc9wltDPkOWEdwLj/WE4xIzyrYhiU2eCzoE9/Nel+INbZWng7hI9xV2QC7ynBwNqU7
	fpUSpYt3EPKA6gNnuKlSKuHvLx6cdaqAlmfxx9KuIyxgwQ2wQEg1VcOLz9LYgQizUbclMY
	bGfYiBrQW43q569yxzmcxxRJ10XsOdqdncJ7I8v91gytz6SKoYRqXAYH9bq4Bg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1791214861;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UVO7LbGOAGo9OqVSQSLUeUOmvwKVDCLK1lhx1pC6RKc=;
	b=iaYKxhgPq4c8WXYxzYb8GcvXDFzSVnavZD2Gu39R1x9qE2H0HDmJxw+X+Fc3yoN4Mz9FPq
	D1wAujRA18sdcAaGkNvQ1eR3fuJG31UXOzVAAr2CzFZUYfglD8U65ZZFQsVyqOnltbGP4s
	aKwFCT9lYwjsnW0RIqyaqQNnlsh/8Ku1qX9Y8va5O6yaP4ET9d/B9dnQUti7xo9eH5pjiN
	+hnFUTM55g2jerQqWctPpe7iPjR2OJaR4cIi0aGjfvg1suQxQNJgt+gkPaS5dj7xiQzvIJ
	An18wy+1qEX1jo6uVizlQyqKzZfYkftCLyDFOjcRBZDMJiBwKw9Da/qoKpWbdQ==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4hz3Wd0RN1zQWZ
	for <net@FreeBSD.org>; Mon, 05 Oct 2026 15:41:01 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org ([127.0.1.5])
	by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 695Ff1bT091598
	for <net@FreeBSD.org>; Mon, 5 Oct 2026 15:41:01 GMT
	(envelope-from bugzilla-noreply@freebsd.org)
Received: (from www@localhost)
	by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 695Ff1ts091597
	for net@FreeBSD.org; Mon, 5 Oct 2026 15:41:01 GMT
	(envelope-from bugzilla-noreply@freebsd.org)
X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f
From: bugzilla-noreply@freebsd.org
To: net@FreeBSD.org
Subject: [Bug 299065] LINT builds are failing on aarch64/amd64 due to missing
 symbols with if_bnxt driver
Date: Mon, 05 Oct 2026 15:41:00 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 15.1-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: ngie@FreeBSD.org
X-Bugzilla-Status: Closed
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: ssaxena@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: assigned_to resolution bug_status
Message-ID: <bug-299065-7501-qiVgDOYonY@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-299065-7501@https.bugs.freebsd.org/bugzilla/>
References: <bug-299065-7501@https.bugs.freebsd.org/bugzilla/>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-net
List-Help: <mailto:freebsd-net+help@freebsd.org>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Subscribe: <mailto:freebsd-net+subscribe@freebsd.org>
List-Unsubscribe: <mailto:freebsd-net+unsubscribe@freebsd.org>
Sender: owner-freebsd-net@FreeBSD.org
List-Id: <freebsd-net.FreeBSD.org>
List-Post: <mailto:freebsd-net@FreeBSD.org>
List-Help: <mailto:freebsd-net+help@FreeBSD.org>
List-Subscribe: <mailto:freebsd-net+subscribe@FreeBSD.org>
List-Unsubscribe: <mailto:freebsd-net+unsubscribe@FreeBSD.org>
List-Owner: <mailto:postmaster@FreeBSD.org>
Precedence: list
MIME-Version: 1.0

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D299065

Enji Cooper <ngie@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|net@FreeBSD.org             |ssaxena@FreeBSD.org
         Resolution|---                         |FIXED
             Status|New                         |Closed

--- Comment #2 from Enji Cooper <ngie@FreeBSD.org> ---
Confirmed fixed -- thank you ssaxena!
https://ci.freebsd.org/job/FreeBSD-stable-15-aarch64-LINT/1255/

--=20
You are receiving this mail because:
You are the assignee for the bug.=

From nobody Tue Oct  6 14:27:33 2026
X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hzdrg3X37z6vQb2
	for <freebsd-net@mlmmj.nyi.freebsd.org>; Tue, 06 Oct 2026 14:27:47 +0000 (UTC)
	(envelope-from paulo@nlink.com.br)
Received: from smtpa.nlink.com.br (smtp.nlink.com.br [187.87.129.25])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4hzdrc09vkz4Scs
	for <freebsd-net@freebsd.org>; Tue, 06 Oct 2026 14:27:43 +0000 (UTC)
	(envelope-from paulo@nlink.com.br)
Authentication-Results: mx1.freebsd.org;
	dkim=pass header.d=nlink.com.br header.s=default header.b=BWCqw0Bx;
	spf=pass (mx1.freebsd.org: domain of paulo@nlink.com.br designates 187.87.129.25 as permitted sender) smtp.mailfrom=paulo@nlink.com.br;
	dmarc=pass (policy=reject) header.from=nlink.com.br
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=nlink.com.br; s=default; x=1791901655; h=Message-ID:Date:
	MIME-Version:User-Agent:Content-Language:To:From:Subject:
	Content-Type:Content-Transfer-Encoding; bh=jfc/MfV/evy4sNqMzdIyg
	nuCqy1KMKhZTposLsAFt3w=; b=BWCqw0Bxq/R15KrPizMEX3yAxg7TsfKQyBV8g
	187hKUMnhmtC/Rw1EDtmtvJ6SCihHI4L8PgPdUokZiq2gTWYanslR1Xm2JsJwIIE
	lABtAV89D/qf5rptjWzeAlC0i9TE7QzV7QeErZCY87eZgTXdBMy8axYqXOvGkPwm
	vq6F9x+f49aaweVuqBbRvntPcgfceAW7LRbt2lfG6czAuA8AwoTmO972pcr/AQmf
	cUKhNye2SHcEx9gxxrois89IzduwuVC/DuIB9OuCey/ZmquEtsbmtb0TxuEsOb4B
	yyGOlpJrX1eB5+0e5pLNr3nogOQX0Rt/PkAuwOVH90ypA/wTA==
Received: (qmail 13386 invoked by uid 89); 6 Oct 2026 11:27:35 -0300
Received: (simscan 1.4.2 ppid 13363 pid 13382 t 0.1483s)
 (scanners: none); 06 Oct 0126 14:27:35 -0000
Received: from iptv.nlink.com.br (HELO ?192.168.27.201?) (paulo@nlink.com.br)
  by smtpa.nlink.com.br with ESMTPSA (TLS_AES_128_GCM_SHA256 encrypted, authenticated); 6 Oct 2026 11:27:35 -0300
Message-ID: <d278a0c6-bc1c-43e7-9d9a-616f0598a1c4@nlink.com.br>
Date: Tue, 6 Oct 2026 11:27:33 -0300
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-net
List-Help: <mailto:freebsd-net+help@freebsd.org>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Subscribe: <mailto:freebsd-net+subscribe@freebsd.org>
List-Unsubscribe: <mailto:freebsd-net+unsubscribe@freebsd.org>
Sender: owner-freebsd-net@FreeBSD.org
List-Id: <freebsd-net.FreeBSD.org>
List-Post: <mailto:freebsd-net@FreeBSD.org>
List-Help: <mailto:freebsd-net+help@FreeBSD.org>
List-Subscribe: <mailto:freebsd-net+subscribe@FreeBSD.org>
List-Unsubscribe: <mailto:freebsd-net+unsubscribe@FreeBSD.org>
List-Owner: <mailto:postmaster@FreeBSD.org>
Precedence: list
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: freebsd-net@freebsd.org
From: Paulo Fragoso <paulo@nlink.com.br>
Subject: Review request: D60083 libalias: index fully specified inbound links
 by remote endpoint
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spamd-Bar: /
X-Spamd-Result: default: False [-0.80 / 15.00];
	DMARC_POLICY_ALLOW(-0.50)[nlink.com.br,reject];
	ONCE_RECEIVED(0.20)[];
	R_DKIM_ALLOW(-0.20)[nlink.com.br:s=default];
	R_SPF_ALLOW(-0.20)[+ip4:187.87.129.0/24];
	MIME_GOOD(-0.10)[text/plain];
	RCPT_COUNT_ONE(0.00)[1];
	ASN(0.00)[asn:28585, ipnet:187.87.128.0/22, country:BR];
	RCVD_COUNT_ONE(0.00)[1];
	RCVD_VIA_SMTP_AUTH(0.00)[];
	MIME_TRACE(0.00)[0:+];
	RCVD_TLS_ALL(0.00)[];
	MID_RHS_MATCH_FROM(0.00)[];
	MLMMJ_DEST(0.00)[freebsd-net@freebsd.org];
	FROM_HAS_DN(0.00)[];
	ARC_NA(0.00)[];
	FROM_EQ_ENVFROM(0.00)[];
	TO_MATCH_ENVRCPT_ALL(0.00)[];
	TO_DN_NONE(0.00)[];
	DKIM_TRACE(0.00)[nlink.com.br:+]
X-Rspamd-Queue-Id: 4hzdrc09vkz4Scs

Hi,

I would like to ask for reviews of D60083:

   https://reviews.freebsd.org/D60083

Problem

With ipfw nat (or ng_nat) and redirect_addr / redirect_port in front
of a simple web service, every inbound connection to public:443 creates
a link with alias_port = 443. All of them land in the same group_in,
and _FindLinkIn() walks that group's grp->full list linearly for every
packet.

This hit a production hosting datacenter where I work as a
consultant: one network thread was pinned at 100% with only a few
hundred packets per second. We could not find the cause at the time.
First we moved from ipfw to pf, and later the service was moved off
FreeBSD to Debian/Proxmox. The datacenter lost a customer because of
it. I found the root cause only later (two and half years later,
with the application's source code and a lab that reproduces it.

The behaviour is old: the same grouping existed in the pre-2021 hash
table, as far back as libalias 1.0/2.1. Anyone running ipfw nat with
redirects in front of a busy service can hit it.

Change

grp->full becomes an RB tree keyed by (dst_addr, dst_port), with a
per-instance sequence number as a newest-first tie-break. That keeps
the current semantics when several links share the same remote
endpoint (3_natin:2_portoverlap depends on it). Partially specified
links keep the existing list. The new field in struct libalias is
appended at the end, because ipfw_nat.ko and ng_nat.ko read
logDesc/packetAliasMode directly through alias_local.h.

Results (16.0-CURRENT, VNET jails over epair, SYNs to one redirected
port, 1000 pps):

                           stock (~170k links)   patched (~141k links)
   LibAliasIn per packet   1 to 2 ms             2 to 4 us
   packets per 10 s        ~7,200 (saturated)    ~10,000 (all offered)
   epair_task CPU          99%                   0.0 to 0.15%

Userland, 100k links in one group: a new SYN goes from about 1.25 ms
to about 600 ns it was really fast.

I also have a backport to 14.0 tested in userland.

adrian@ accepted it and asked for more networking people to look at
it. I am happy to run more tests, for example ng_nat or UDP endpoint
independent mapping, if anyone has a scenario in mind.

Thanks,
Paulo Fragoso

